Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not call testdata.Path when defining flags #1394

Merged
merged 1 commit into from
Jul 27, 2017
Merged

Do not call testdata.Path when defining flags #1394

merged 1 commit into from
Jul 27, 2017

Conversation

menghanl
Copy link
Contributor

So we could replace the testdata path with flags.

@menghanl menghanl requested a review from dfawley July 27, 2017 20:38
@dfawley dfawley merged commit e64ff5d into grpc:master Jul 27, 2017
@dfawley dfawley modified the milestone: 1.6 Release Aug 28, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees
No one assigned
Labels
Type: Testing
Projects
None yet
Milestone
1.6 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@menghanl @dfawley