Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bufconn.Close to not be blocking #1377

Merged
merged 1 commit into from
Jul 20, 2017
Merged

Fix bufconn.Close to not be blocking #1377

merged 1 commit into from
Jul 20, 2017

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Jul 18, 2017

This should fix a race in the end to end tests where Close may be called while Dialing.

@dfawley dfawley merged commit 2bb3182 into grpc:master Jul 20, 2017
@dfawley dfawley modified the milestone: 1.6 Release Aug 28, 2017
@dfawley dfawley deleted the bufconn_fix branch August 29, 2017 20:16
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees
No one assigned
Labels
Type: Testing
Projects
None yet
Milestone
1.6 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @menghanl