Update Native.DetectWindowsVersion() to consider Windows Server 2019 to be Window Server #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to be WindowsServer whenever it is not a Workstation (so, even when the server is configured to be a Domain Controller with PlatformType == 2)
The committers listed above are authorized under a signed CLA. |
|
Looks good to me. Can merge once CLA is signed. |
JamesNK
approved these changes
Jun 26, 2024
JamesNK
pushed a commit
to JamesNK/grpc-dotnet
that referenced
this pull request
Jun 28, 2024
…to be Window Server (grpc#2468)
stanley-cheung
pushed a commit
that referenced
this pull request
Jul 1, 2024
…to be Window Server (#2468) (#2473) Co-authored-by: William Rall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the IsWindowsServer check to be "!= VER_NT_WORKSTATION" instead of "== VER_NT_SERVER" because VER_NT_DOMAIN_CONTROLLER (2) is not correctly being considered as Windows Server.
Fixes #2467