Fix memory leak when using call context propagation with cancellation token #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
force-pushed
the
jamesnk/propagation-leak
branch
from
53b2d35
to
663bf9c
Compare
mgravell
reviewed
Apr 28, 2024
| { | ||
| try | ||
| { | ||
| return await task.ConfigureAwait(false); |
There was a problem hiding this comment.
Might this be a rare occasion when ContinueWith makes more sense?
There was a problem hiding this comment.
Why would it be better here? From what I know, async/await is preferred.
mgravell
approved these changes
Apr 28, 2024
oguzhand95
referenced
this pull request
in cerbos/cerbos-sdk-net
May 31, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Google.Protobuf](https://togithub.com/protocolbuffers/protobuf) | `3.26.1` -> `3.27.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [Grpc.Net.Client](https://togithub.com/grpc/grpc-dotnet) | `2.62.0` -> `2.63.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.NET.Test.Sdk](https://togithub.com/microsoft/vstest) | `17.9.0` -> `17.10.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>grpc/grpc-dotnet (Grpc.Net.Client)</summary> ### [`v2.63.0`](https://togithub.com/grpc/grpc-dotnet/releases/tag/v2.63.0) ##### What's Changed - Prevent block inside ResolveAsync from blocking PollingResolver.Refresh by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2385](https://togithub.com/grpc/grpc-dotnet/pull/2385) - Bump follow-redirects from 1.15.4 to 1.15.6 in /testassets/InteropTestsGrpcWebWebsite/Tests by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/grpc/grpc-dotnet/pull/2392](https://togithub.com/grpc/grpc-dotnet/pull/2392) - Update microsoft-support.md by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2403](https://togithub.com/grpc/grpc-dotnet/pull/2403) - fix a couple typos in README.md by [@​jjanuszkiewicz](https://togithub.com/jjanuszkiewicz) in [https://github.com/grpc/grpc-dotnet/pull/2397](https://togithub.com/grpc/grpc-dotnet/pull/2397) - Interrupt existing subchannel connect attempt when reconnect is requested by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2410](https://togithub.com/grpc/grpc-dotnet/pull/2410) - Update Directory.Packages.props by [@​WeihanLi](https://togithub.com/WeihanLi) in [https://github.com/grpc/grpc-dotnet/pull/2413](https://togithub.com/grpc/grpc-dotnet/pull/2413) - [#​2401](https://togithub.com/grpc/grpc-dotnet/issues/2401) Add new TFM's so package dependency can be removed by [@​thompson-tomo](https://togithub.com/thompson-tomo) in [https://github.com/grpc/grpc-dotnet/pull/2402](https://togithub.com/grpc/grpc-dotnet/pull/2402) - support `ReadAllAsync` for netstandard2.0 by [@​WeihanLi](https://togithub.com/WeihanLi) in [https://github.com/grpc/grpc-dotnet/pull/2411](https://togithub.com/grpc/grpc-dotnet/pull/2411) - Fix ObjectDisposedException message by [@​drewnoakes](https://togithub.com/drewnoakes) in [https://github.com/grpc/grpc-dotnet/pull/2415](https://togithub.com/grpc/grpc-dotnet/pull/2415) - Enable multiple connections with WinHttpHandler by default by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2416](https://togithub.com/grpc/grpc-dotnet/pull/2416) - Fix memory leak when using call context propagation with cancellation token by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2421](https://togithub.com/grpc/grpc-dotnet/pull/2421) - Fix HTTP/3 test errors on .NET 6 by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2423](https://togithub.com/grpc/grpc-dotnet/pull/2423) - Add semaphore to limit subchannel connect to prevent race conditions by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2422](https://togithub.com/grpc/grpc-dotnet/pull/2422) - Don't capture async locals in resolver by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2426](https://togithub.com/grpc/grpc-dotnet/pull/2426) - Update Grpc.Tools to 2.63 by [@​apolcyn](https://togithub.com/apolcyn) in [https://github.com/grpc/grpc-dotnet/pull/2429](https://togithub.com/grpc/grpc-dotnet/pull/2429) - Bump 2.63.x branch to 2.63.0-pre1 by [@​apolcyn](https://togithub.com/apolcyn) in [https://github.com/grpc/grpc-dotnet/pull/2430](https://togithub.com/grpc/grpc-dotnet/pull/2430) - Fix build on v2.63.x - cherry pick [https://github.com/grpc/grpc-dotnet/pull/2437](https://togithub.com/grpc/grpc-dotnet/pull/2437) by [@​apolcyn](https://togithub.com/apolcyn) in [https://github.com/grpc/grpc-dotnet/pull/2442](https://togithub.com/grpc/grpc-dotnet/pull/2442) - Bump 2.63.x to stable release by [@​apolcyn](https://togithub.com/apolcyn) in [https://github.com/grpc/grpc-dotnet/pull/2440](https://togithub.com/grpc/grpc-dotnet/pull/2440) ##### New Contributors - [@​jjanuszkiewicz](https://togithub.com/jjanuszkiewicz) made their first contribution in [https://github.com/grpc/grpc-dotnet/pull/2397](https://togithub.com/grpc/grpc-dotnet/pull/2397) - [@​thompson-tomo](https://togithub.com/thompson-tomo) made their first contribution in [https://github.com/grpc/grpc-dotnet/pull/2402](https://togithub.com/grpc/grpc-dotnet/pull/2402) - [@​drewnoakes](https://togithub.com/drewnoakes) made their first contribution in [https://github.com/grpc/grpc-dotnet/pull/2415](https://togithub.com/grpc/grpc-dotnet/pull/2415) **Full Changelog**: grpc/grpc-dotnet@v2.62.0...v2.63.0 </details> <details> <summary>microsoft/vstest (Microsoft.NET.Test.Sdk)</summary> ### [`v17.10.0`](https://togithub.com/microsoft/vstest/releases/tag/v17.10.0) ##### What's Changed - Add missing runtimeconfig.json file for 8.0 by [@​MarcoRossignoli](https://togithub.com/MarcoRossignoli) in [https://github.com/microsoft/vstest/pull/4792](https://togithub.com/microsoft/vstest/pull/4792) - Localized file check-in by OneLocBuild Task: Build definition ID 1222: Build ID [`2338548`](https://togithub.com/microsoft/vstest/commit/2338548) by [@​dotnet-bot](https://togithub.com/dotnet-bot) in [https://github.com/microsoft/vstest/pull/4794](https://togithub.com/microsoft/vstest/pull/4794) - Disable testhost prestart by [@​nohwnd](https://togithub.com/nohwnd) in [https://github.com/microsoft/vstest/pull/4833](https://togithub.com/microsoft/vstest/pull/4833) - Terminal logger fixes by [@​nohwnd](https://togithub.com/nohwnd) in [https://github.com/microsoft/vstest/pull/4834](https://togithub.com/microsoft/vstest/pull/4834) - Add RiscV64 by [@​nohwnd](https://togithub.com/nohwnd) in [https://github.com/microsoft/vstest/pull/4838](https://togithub.com/microsoft/vstest/pull/4838) - Add deterministic source mapping storing for Microsoft.CodeCoverage by [@​jakubch1](https://togithub.com/jakubch1) in [https://github.com/microsoft/vstest/pull/4849](https://togithub.com/microsoft/vstest/pull/4849) - Fix terminal logger encoding & error by [@​nohwnd](https://togithub.com/nohwnd) in [https://github.com/microsoft/vstest/pull/4853](https://togithub.com/microsoft/vstest/pull/4853) - Update sourcebuild configuration to build net previous and net current by [@​Evangelink](https://togithub.com/Evangelink) in [https://github.com/microsoft/vstest/pull/4856](https://togithub.com/microsoft/vstest/pull/4856) - Updating version of Microsoft.VisualStudio.Interop to 17.10 by [@​MSLukeWest](https://togithub.com/MSLukeWest) in [https://github.com/microsoft/vstest/pull/4866](https://togithub.com/microsoft/vstest/pull/4866) - Add VSTEST_DIAG_VERBOSITY to help by [@​nohwnd](https://togithub.com/nohwnd) in [https://github.com/microsoft/vstest/pull/4882](https://togithub.com/microsoft/vstest/pull/4882) - Fix feature flag name by [@​nohwnd](https://togithub.com/nohwnd) in [https://github.com/microsoft/vstest/pull/4885](https://togithub.com/microsoft/vstest/pull/4885) - Improve terminal logger by [@​nohwnd](https://togithub.com/nohwnd) in [https://github.com/microsoft/vstest/pull/4877](https://togithub.com/microsoft/vstest/pull/4877) - Remove PackageLicenseFile preventing PackageLicenseExpression from working by [@​lahma](https://togithub.com/lahma) in [https://github.com/microsoft/vstest/pull/4890](https://togithub.com/microsoft/vstest/pull/4890) - Add GitHub Actions logger by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/microsoft/vstest/pull/4906](https://togithub.com/microsoft/vstest/pull/4906) - Ensure to send a session complete event by [@​drognanar](https://togithub.com/drognanar) in [https://github.com/microsoft/vstest/pull/4878](https://togithub.com/microsoft/vstest/pull/4878) - specify Win10 + maxversiontested to enable xaml APIs to be used in tests running under testhost.exe by [@​ChrisGuzak](https://togithub.com/ChrisGuzak) in [https://github.com/microsoft/vstest/pull/4888](https://togithub.com/microsoft/vstest/pull/4888) - Make VSTest repo buildable in VMR non-source-build by [@​ViktorHofer](https://togithub.com/ViktorHofer) in [https://github.com/microsoft/vstest/pull/4920](https://togithub.com/microsoft/vstest/pull/4920) - Migrate pipelines by [@​nohwnd](https://togithub.com/nohwnd) in [https://github.com/microsoft/vstest/pull/4921](https://togithub.com/microsoft/vstest/pull/4921) - Add test name to MSBuild where we have frame. by [@​nohwnd](https://togithub.com/nohwnd) in [https://github.com/microsoft/vstest/pull/4935](https://togithub.com/microsoft/vstest/pull/4935) - \[rel/17.10] Add list of known TestingPlatform dlls by [@​nohwnd](https://togithub.com/nohwnd) in [https://github.com/microsoft/vstest/pull/4982](https://togithub.com/microsoft/vstest/pull/4982) And many infrastructure related changes and updates. ##### New Contributors - [@​ellahathaway](https://togithub.com/ellahathaway) made their first contribution in [https://github.com/microsoft/vstest/pull/4785](https://togithub.com/microsoft/vstest/pull/4785) - [@​MSLukeWest](https://togithub.com/MSLukeWest) made their first contribution in [https://github.com/microsoft/vstest/pull/4866](https://togithub.com/microsoft/vstest/pull/4866) - [@​lahma](https://togithub.com/lahma) made their first contribution in [https://github.com/microsoft/vstest/pull/4890](https://togithub.com/microsoft/vstest/pull/4890) - [@​ChrisGuzak](https://togithub.com/ChrisGuzak) made their first contribution in [https://github.com/microsoft/vstest/pull/4888](https://togithub.com/microsoft/vstest/pull/4888) **Full Changelog**: microsoft/vstest@v17.9.0...v17.10.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cerbos/cerbos-sdk-net). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImJvdHMiLCJjaG9yZSIsImNpIl19--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Oğuzhan Durgun <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2419
There was an incorrect assumption that the disposable call was always disposed of by the client. It isn't, which could create a memory leak under the right situation (context propagation + long lasting cancellation token + many unary calls)
Fix is to make the interceptor configure the returned call type to automatically dispose its own state once finished with reading the response.