Example: route guide client cleanup #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match the tutorial code: the `channel` variable should be a local variable rather than a member of `Client`.
|
lgtm, @mraleph can you give this an eng review? |
|
LGTM. There is not much to review really. (I don't have merge/review rights yet though so you will have to merge @mit-mit ) |
acoutts
added a commit
to bottlepay/grpc-dart
that referenced
this pull request
Sep 16, 2020
Example: route guide client cleanup (grpc#350)
|
Thank you both for the quick review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
channelvariable should be a local variable rather than a member ofClient. (This is in part a followup to #286 and grpc/grpc.io#386.)@sigurdm @mit-mit
I've manually tested the route guide example to ensure that it still works as intended.
Related: grpc/grpc.io#395