-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix go 1.18 installation compatibility issue #37
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@lyonlai please help to review and merge, thank you very much! |
thanks for the contribution @wilsonwu . I'll take a look soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM but the build's failing. will require some extra effort from you. @wilsonwu
@lyonlai seems the job broken for long time, I tried to solve it, please help to run it. |
@lyonlai please help to rerun, already fixed in my repo: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing the go-releaser for 1.18. others LGTM
Thanks you for your. contribution @wilsonwu |
Fix go 1.18 installation compatibility issue:
solve #33