Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go 1.18 installation compatibility issue #37

Merged
merged 7 commits into from
Jun 21, 2022

Conversation

wilsonwu
Copy link
Contributor

Fix go 1.18 installation compatibility issue:
image

solve #33

@google-cla
Copy link

google-cla bot commented Jun 16, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@wilsonwu
Copy link
Contributor Author

@lyonlai please help to review and merge, thank you very much!

@wilsonwu wilsonwu changed the title Fix go 1.18 installation compatibility issue Fix go 1.18 installation compatibility issue on macOS Jun 16, 2022
@wilsonwu wilsonwu changed the title Fix go 1.18 installation compatibility issue on macOS Fix go 1.18 installation compatibility issue Jun 16, 2022
@lyonlai
Copy link
Collaborator

lyonlai commented Jun 17, 2022

thanks for the contribution @wilsonwu . I'll take a look soon

Copy link
Collaborator

@lyonlai lyonlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM but the build's failing. will require some extra effort from you. @wilsonwu

@wilsonwu
Copy link
Contributor Author

@lyonlai seems the job broken for long time, I tried to solve it, please help to run it.

@wilsonwu wilsonwu requested a review from lyonlai June 20, 2022 08:14
@wilsonwu
Copy link
Contributor Author

@lyonlai please help to rerun, already fixed in my repo:
image

Copy link
Collaborator

@lyonlai lyonlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing the go-releaser for 1.18. others LGTM

.github/workflows/main.yml Outdated Show resolved Hide resolved
@wilsonwu wilsonwu requested a review from lyonlai June 21, 2022 03:49
@lyonlai
Copy link
Collaborator

lyonlai commented Jun 21, 2022

Thanks you for your. contribution @wilsonwu

@lyonlai lyonlai merged commit 36143bb into grpc-ecosystem:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants