Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github action on pull request #3

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

lyonlai
Copy link
Collaborator

@lyonlai lyonlai commented Apr 9, 2021

No description provided.

@lyonlai lyonlai requested a review from alecthomas April 9, 2021 04:48
@lyonlai lyonlai force-pushed the ylai/github-action-on-pull-request branch from d344ba3 to 7b85478 Compare April 9, 2021 04:53
CODEOWNERS Outdated
@@ -0,0 +1,3 @@
## This defines the code owner of the repository

@lyonlai @alecthomas
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some more people here? @jvmakine and @juliaogris perhaps?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup. for sure

@lyonlai lyonlai force-pushed the ylai/github-action-on-pull-request branch from 7b85478 to 9bdd148 Compare April 9, 2021 06:02
@lyonlai lyonlai merged commit 0fab17c into master Apr 9, 2021
@lyonlai lyonlai deleted the ylai/github-action-on-pull-request branch April 13, 2021 04:27
dpup referenced this pull request in dpup/protoc-gen-grpc-gateway-ts Apr 18, 2024
Update Typescript types to match what our server returns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants