Fix module name and imports #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do you see the test for this? @atreya2011 |
|
@atreya2011 I've just updated the github action to run test on pull request. please rebase and give it a try |
|
@lyonlai Thank you for approving this. Unfortunately, I am unable to see the tests 😓 Let me try rebasing ... |
atreya2011
force-pushed
the
fix-module-name
branch
from
8e8b20b
to
22a4304
Compare
|
@lyonlai Upon rebasing I can see the tests. Thanks for this 🙏🏼 |
dpup
referenced
this pull request
in dpup/protoc-gen-grpc-gateway-ts
Apr 18, 2024
Handle well-known wrapper types with native Typescript types, matching gprc-gateway serialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the module name and imports were not updated to
grpc-ecosystemand fixed it in all the appropriate files.Let me know if I have missed anything 🙏🏼