-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc for opentracing support #987
Add doc for opentracing support #987
Conversation
Mention the fact that the client must be initialized with an opentracing interceptor to allow the propagation of spans through the gateway.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #987 +/- ##
=======================================
Coverage 53.43% 53.43%
=======================================
Files 40 40
Lines 4027 4027
=======================================
Hits 2152 2152
Misses 1676 1676
Partials 199 199 Continue to review full report at Codecov.
|
@googlebot I signed it! |
Having more doc on this topic was actually suggested here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant, thanks for this!
Not sure what's up with Googlebot, @achew22? |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
I signed the CLA logged with one Google account, but the commit was made with another one. All good now |
Mention the fact that the client must be initialized with an opentracing interceptor to allow the propagation of spans through the gateway.
I originally followed the doc but completely forgot about adding this interceptor to the gRPC client. Thought it might help others save time.
Please let me know if this isn't accurate enough (or wrong!).