-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use json camel case when GetUseJSONNamesForFields is enabled #985
Use json camel case when GetUseJSONNamesForFields is enabled #985
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #985 +/- ##
=========================================
Coverage ? 53.43%
=========================================
Files ? 40
Lines ? 4027
Branches ? 0
=========================================
Hits ? 2152
Misses ? 1676
Partials ? 199
Continue to review full report at Codecov.
|
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @xin-au, thanks for your contribution! Could you explain what this fixes? It looks like a bug fix to me. If you could raise an issue that is fixed by this PR that'd be great. Don't have to go into too much detail. If not, an explanation here would suffice. If this is indeed a bug fix, we should try to add some tests to prevent this from regressing in the future. Could you look into adding some tests please?
Thanks again!
Hi @johanbrandhorst , thanks for your suggestions and details! |
The issue associated with this PR. #986 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, LGTM!
Thanks @johanbrandhorst ! |
…osystem#985) * Use json name when GetUseJSONNamesForFields is enabled * Optimzed an if statement * Merge two if statements * Convert parameters to lower camel case in url * Revert services.go file * Fix an unit test * Update bazel file * Add an unit test for testing json camel case * Add an unit test for testing code without enabling json camel case * Add more corner cases Fixes grpc-ecosystem#986
Use json camel case when GetUseJSONNamesForFields is enabled