Fix query.go to avoid invalid protobuf assumptions #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The golang/protobuf compatibility agreement reserves the right add/remove XXX fields and methods. Fix this code to avoid assuming: * that XXX_WellKnownType always exists (it won't in the future). Instead, it should determine whether a message is a well-known type based on its full name. * that Go struct field indexes are stable (they aren't). An internal field may be added to the front of the message, causing the current assumptions to be invalidated. Instead, access the struct field by name, which will not change.
johanbrandhorst
approved these changes
Jul 8, 2019
|
I've triggered a rerun of the flaky test. |
|
Thanks for your contribution! When will these changes be breaking? I.e. what version of golang/protobuf will require this commit to work? |
When
Thus, anything that depends on the new implementation or v1.4.0+ will be broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The golang/protobuf compatibility agreement reserves the right add/remove
XXX fields and methods.
Fix this code to avoid assuming:
Instead, it should determine whether a message is a well-known type
based on its full name.
An internal field may be added to the front of the message,
causing the current assumptions to be invalidated.
Instead, access the struct field by name, which will not change.