docs/customizingyourgateway: add ?pretty example #954
Conversation
srenatus
force-pushed
the
sr/docs/add-pretty-example
branch
from
503e4af
to
fdd66ab
Compare
docs/_docs/customizingyourgateway.md
Outdated
| prettier := func(h http.Handler) http.Handler { | ||
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| defer h.ServeHTTP(w, r) | ||
| // if the "Accept" is set and NOT */* (sent by curl), keep it as-is |
There was a problem hiding this comment.
Why does this need special casing around */*?
There was a problem hiding this comment.
It doesn't, in general. However, all folks I know (small sample) would end up using curl on that endpoint, and curl sends Accept: */* by default. So, if we only check that an Accept header was not provided, this will not work for curl users.
There was a problem hiding this comment.
If figured, if you do not care (i.e. "accept */*"), we might a well override your choice 😄
There was a problem hiding this comment.
What about removing this check altogether? Any Accept header could be overridden when the pretty parameter is present, maybe? What cases would that mess with?
There was a problem hiding this comment.
Oh you're right. In this example, that's surely fine. I was thinking better safe than sorry; but it's fine here.
srenatus
force-pushed
the
sr/docs/add-pretty-example
branch
from
fdd66ab
to
cd255b3
Compare
As discussed in slack. The code is rough, but should illustrate the point. Signed-off-by: Stephan Renatus <[email protected]>
srenatus
force-pushed
the
sr/docs/add-pretty-example
branch
from
cd255b3
to
b9a550b
Compare
|
Thanks for your contribution! |
As discussed in slack. The code is rough, but should illustrate the point. Signed-off-by: Stephan Renatus <[email protected]>
As discussed in slack. The code is rough, but should illustrate the
point.