Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade generator and runtime versions #889

Merged
merged 5 commits into from
Mar 2, 2019
Merged

Upgrade generator and runtime versions #889

merged 5 commits into from
Mar 2, 2019

Conversation

johanbrandhorst
Copy link
Collaborator

@johanbrandhorst johanbrandhorst commented Mar 2, 2019 •
edited
Loading

Go 1.12
Node 10.15.2
Protoc 3.7.0
Swagger Codegen 2.4.2 see #889 (comment)

Fixes #885

@johanbrandhorst johanbrandhorst force-pushed the update-go-1.12 branch 3 times, most recently from ff24f1d to 7fec82c Compare March 2, 2019 13:10
@johanbrandhorst
Copy link
Collaborator Author

Decided against upgrading swagger-codegen after battling with it for a bit. Seems to be even more broken upstream.

@johanbrandhorst
Copy link
Collaborator Author

Bazel build is failing because it's still using Go 1.11. I'm not sure how to update this. @drigz @achew22?

@johanbrandhorst johanbrandhorst force-pushed the update-go-1.12 branch 3 times, most recently from 1a925a0 to 2a1e7e7 Compare March 2, 2019 14:02
@johanbrandhorst
Copy link
Collaborator Author

johanbrandhorst commented Mar 2, 2019 •
edited
Loading

Bazel build is failing because it's still using Go 1.11. I'm not sure how to update this. @drigz @achew22?

I updated rules_go and gazelle and ran bazel run gazelle but the tests are failing still. I'm suspicious of the change that bazel run gazelle made to examples/proto/examplepb/BUILD.bazel, but I don't know enough about Bazel to say why. Help appreciated.

@johanbrandhorst johanbrandhorst force-pushed the update-go-1.12 branch 2 times, most recently from 9a5c023 to b891478 Compare March 2, 2019 19:27
@codecov-io
Copy link

Codecov Report

Merging #889 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #889   +/-   ##
=======================================
  Coverage   53.69%   53.69%           
=======================================
  Files          39       39           
  Lines        3926     3926           
=======================================
  Hits         2108     2108           
  Misses       1621     1621           
  Partials      197      197

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc6fc94...b891478. Read the comment docs.

@johanbrandhorst johanbrandhorst merged commit 15c52a7 into master Mar 2, 2019
@johanbrandhorst johanbrandhorst deleted the update-go-1.12 branch March 2, 2019 20:17
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
@johanbrandhorst
Upgrade generator and runtime versions (grpc-ecosystem#889)
c317ef5 
* Upgrade generator and runtime versions

Go 1.12
Node 10.15.2
Protoc  3.7.0
Swagger Codegen 2.4.2

* Fix vet error discovered by Go 1.12

* Regenerate protofiles with protoc 3.7.0

* Update expected error in when specifying incorrect flags

Apparently this message changed with Go 1.12

* Use explicit versioning of build environment in docker commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achew22 achew22 achew22 left review comments

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johanbrandhorst @codecov-io @achew22 @googlebot