Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use case where we want to customise the error handler, for example, adding html templates and sending back the error depending on whether the client allows html or not. The library currently allows us to override the
HTTPError
caused by the grpc request but the not errors caused by the server muxer. Furthermore, the incoming client request is not propagated toHTTPError
so it is not possible to figure out theAccept
header of the request.This PR adds these two functionalities: a
OtherErrorHandler
variable which can be overridden likeHTTPError
, and forwarding the incoming request to the error handlers so they can have more flexibility in determining how to handle the errors.