-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Service, Method, Message Identifiers to be CamelCased #866
Updated Service, Method, Message Identifiers to be CamelCased #866
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
CLAs look good, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #866 +/- ##
==========================================
+ Coverage 52.95% 52.99% +0.03%
==========================================
Files 39 39
Lines 3907 3910 +3
==========================================
+ Hits 2069 2072 +3
Misses 1642 1642
Partials 196 196
Continue to review full report at Codecov.
|
Thanks so much for the PR! Do you think you could add a test that verifies this behavior so we don't accidentally regress in the future? |
@achew22 Yes, I'll add a commit for the test in the PR. Thanks for checking. |
1db7a68
to
22b06c2
Compare
The incompatibility caused between the generated .pb.gw.go and .pb.go files due to inconsistent identifier capitalization has been fixed here. Logic from protoc-gen-go for the Message, Service and Method Names is ported to protoc-gen-grpc-gateway. Have made changes in the template.go file and have written a test so we don't regress this in the future. This fixes grpc-ecosystem#683
22b06c2
to
5b49183
Compare
I have added the test and updated the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution! |
The incompatibility caused between the generated .pb.gw.go
and .pb.go files due to inconsistent identifier capitalization
has been fixed here.
Logic from protoc-gen-go for the Message, Service and Method
Names is ported to protoc-gen-grpc-gateway.
Have made changes in the template.go file and have written a
test so we don't regress this in the future.
This fixes #683