Correct wellKnownTypeConv function references #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
changed the title
johanbrandhorst
changed the title
| ".google.protobuf.FloatValue": "runtime.FloatValue", | ||
| ".google.protobuf.DoubleValue": "runtime.DoubleValue", | ||
| ".google.protobuf.BoolValue": "runtime.BoolValue", | ||
| ".google.protobuf.StringValue": "runtime.String", |
There was a problem hiding this comment.
@johanbrandhorst seems it's still broken.
I try doing go install where my *.pb.gw.go files are.
Throws: cannot assign string to protoReq.Domain (type *wrappers.StringValue) in multiple assignment
There was a problem hiding this comment.
One way I could find is to update our runtime/convert.go to support StringValue.
func StringValue(val string) (*wrappers.StringValue, error) {
return &wrappers.StringValue{Value: val}, nil
}
and keep the map here in types.go as:
".google.protobuf.BoolValue": "runtime.BoolValue"
|
Sigh it's clear to me that we need a little more time to work this out. I agree that your suggestion makes sense, can you submit a new PR? We need to add some examples in this area at the same time. I will revert my change to fix master. |
|
Sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct wellKnownTypeConv function references.
Fixes #808