ci: add job for building binaries for releases #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now I haven't the foggiest idea how we're going to be able to test this unfortunately - any ideas? |
|
I didn't expect the release builds to run, perhaps we should only run those on tags as well? |
Codecov Report
@@ Coverage Diff @@
## master #793 +/- ##
=======================================
Coverage 53.39% 53.39%
=======================================
Files 30 30
Lines 3362 3362
=======================================
Hits 1795 1795
Misses 1392 1392
Partials 175 175Continue to review full report at Codecov.
|
This will trigger a build of a linux, darwin and windows build of protoc-gen-grpc-gateway and protoc-gen-swagger on every new tag matching the semver regex.
johanbrandhorst
force-pushed
the
add-automatic-release-binaries
branch
from
ad144dd
to
c1b8be2
Compare
|
Disabled the release builds for non-tags |
|
So I think the only way to really test this is to make a new release 🎉 |
|
LGTM. I'm not merging because there is a chance you want to watch the next run. Feel free to merge at will |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will trigger a build of a linux, darwin and windows
build of protoc-gen-grpc-gateway and protoc-gen-swagger
on every new tag matching the semver regex.
Fixes #790