Fix a complie error in generated go files #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regenerated files with github.com/golang/protobuf@68415e7123da32b07eab49c96d2c4d6158360e9b
Fixes #67. protoc-gen-go started to keep unused imports of .proto files. So we need to map google/api/annotation.proto to a valid golang import path. Another possible solution was to map the proto file to some harmless package, e.g. "fmt". But it would be safer to map it to a valid path.
yugui
added a commit
that referenced
this pull request
Dec 10, 2015
Fix a complie error in generated go files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67.
protoc-gen-go started to keep unused imports of .proto files.
So we need to map google/api/annotation.proto to a valid golang import path.
Another possible solution was to map the proto file to some harmless package,
e.g. "fmt". But it would be safer to map it to a valid path.