add OpenTracing support to docs #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please rebase this off of maytter please? |
theRealWardo
force-pushed
the
tracing-docs
branch
from
f6265b2
to
13d4478
Compare
|
@achew22 I assume you meant |
|
Yep -- sorry about that. Typing is hard |
Codecov Report
@@ Coverage Diff @@
## master #705 +/- ##
=======================================
Coverage 56.54% 56.54%
=======================================
Files 30 30
Lines 3040 3040
=======================================
Hits 1719 1719
Misses 1152 1152
Partials 169 169Continue to review full report at Codecov.
|
|
As always @theRealWardo, thanks so much! It's a pleasure getting to do this with you |
dmacthedestroyer
pushed a commit
to dmacthedestroyer/grpc-gateway
that referenced
this pull request
Aug 2, 2018
* Add explicit dependency versions (grpc-ecosystem#696) Version constraints are copied from existing Bazel rules. In the future, these version upgrades must be performed atomically. * Add OpenTracing support to docs (grpc-ecosystem#705) * protoc-gen-swagger: support all well-known wrapper types There were a few well-known wrapper types missing from the wkSchemas map. In specific UInt32Value, UInt64Value and BytesValue. This change handles them (and maps them to the same swagger types as the non-wrapped values) This also fixes the mapping of Int64Value. The Int64Value handling maps the value to a swagger integer. The documentation for Int64Value indicates that it should be mapped to a JSON string (also the mapping for normal int64 in protoc-gen-swagger maps it to a string, so this was inconsistent.) * Add test case and proposed fix for path component with trailing colon (and string) (grpc-ecosystem#708) * If a pattern has no verb, match with a verb arg appended to last component Parsing out a "verb" from the input path is a convenience for parsing. Whether the colon and string are _actually_ a verb depends on the matching HTTP rule. This change gives a verb-less pattern a chance to match a path by assuming the colon+string suffix are a part of the final component. Fixes grpc-ecosystem#224 Signed-off-by: James Hamlin <[email protected]> * Fix up examples * Make support paths option Make protoc-gen-grpc-gateway support paths option such like golang/protobuf#515.
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #348