Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openapiv2_json_name field option to specify non alphanumeric characters in JSON property name #686

Closed
wants to merge 1 commit into from

Conversation

co3k
Copy link
Contributor

@co3k co3k commented Jun 28, 2018

proto3 provides json_name option by default (see also https://developers.google.com/protocol-buffers/docs/proto3#json)
but we cannot use this option because it converts snake_cased field name to camelCased one. It means we should have
our own json_name field option for this purpose to keep backward compatibility.

…acters in JSON property name

proto3 provides json_name option by default (see also https://developers.google.com/protocol-buffers/docs/proto3#json)
but we cannot use this option because it converts snake_cased field name to camelCased one. It means we should have
our own json_name field option for this purpose to keep backward compatibility.
@co3k co3k force-pushed the support_json_name_field_tag branch from 077457a to 705dd8a Compare June 28, 2018 16:56
@co3k
Copy link
Contributor Author

co3k commented Jun 28, 2018

Oh, I didn't noticed about #375 and #681.

If we don't need to keep compatibility of existing generated swagger definitions, we can choose #681 approach instead of this pull request.

@johanbrandhorst
Copy link
Collaborator

This is being considered in #546

@co3k co3k deleted the support_json_name_field_tag branch September 9, 2018 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants