Fix error field always in chunk response
#64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
yugui
added a commit
that referenced
this pull request
Oct 22, 2015
Fix `error` field always in chunk response
ithinker1991
pushed a commit
to tronprotocol/grpc-gateway
that referenced
this pull request
Jun 20, 2018
…ctionSign fix : change high case to low
This was referenced Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
responseStreamErrorwas an embedded object and not a pointer, it was always added to the response (theomitemptydidn't work).Moving it to be a pointer solves the problem and makes good results always have only
resultfield, while errors only have theerrorfield.