Skip unnecessary steps in USE_BAZEL builds on TravisCI #622
Conversation
.travis.yml
Outdated
| @@ -12,34 +12,55 @@ cache: | |||
| - $HOME/.cache/_grpc_gateway_bazel | |||
| before_install: | |||
| - if [ "${USE_BAZEL}" = true ]; then ./.travis/install-bazel.sh 0.12.0; fi | |||
There was a problem hiding this comment.
Can you make this line match the test style you used below?
There was a problem hiding this comment.
Do you mean just if test "${USE_BAZEL} = true; then? Or are you thinking about something like test "${USE_BAZEL}" = true && ./.travis/install-bazel.sh?
I did not touch those steps for two reasons.
- Bazel-related steps are less than others. So they does not bloat up the configuration very much even if I left them as they are.
- I can't simply replace them with
test "${USE_BAZEL}" = true && ./.travis/install-bazel.sh ...because whole of the step must have exit code 0 on-z ${USE_BAZEL}.
There was a problem hiding this comment.
The 2nd one is is the reason I was looking for. WDYT about consolidating version numbers into the env section?
There was a problem hiding this comment.
OK. Then, are you ok for keeping if [ "${USE_BAZEL} = true ]; then as is?
WDYT about consolidating version numbers into the env section?
I think it is a good opportunity to do it. I'll push another commit later.
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
==========================================
+ Coverage 59.28% 60.26% +0.98%
==========================================
Files 28 30 +2
Lines 2780 3030 +250
==========================================
+ Hits 1648 1826 +178
- Misses 971 1039 +68
- Partials 161 165 +4
Continue to review full report at Codecov.
|
No description provided.