-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support delete method in swagger generator #616
Conversation
c212679
to
85b3cb8
Compare
Thanks for your contribution! The upstream issue appears fixed, can you rebase to trigger another build? |
2ef4b04
to
128f7ef
Compare
https://travis-ci.org/grpc-ecosystem/grpc-gateway/jobs/370802179 (Go 1.10.x; Would you mind rebasing the branch again? |
Confirmed in https://travis-ci.org/grpc-ecosystem/grpc-gateway/builds/370873461. The branch is safe to merge. I can merge this PR if it looks good to @achew22. |
Codecov Report
@@ Coverage Diff @@
## master #616 +/- ##
=======================================
Coverage 59.28% 59.28%
=======================================
Files 28 28
Lines 2780 2780
=======================================
Hits 1648 1648
Misses 971 971
Partials 161 161
Continue to review full report at Codecov.
|
128f7ef
to
dfac412
Compare
dfac412
to
5432d30
Compare
@yugui done 🙂 |
Can you change one of the proto files to exhibit this new behavior and run |
90e1c41
to
f21234d
Compare
f21234d
to
437255e
Compare
I've added simple endpoint exhibiting the new behavior to the examples @achew22 |
@BlackDahila, I think this is good to go. Thanks so much for your contribution! I look forward to doing it again soon. |
Solves #559 and generates query parameters for the
delete
method.