Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, the
handleSend
function is closing overerr
from the outer function. This trips up the Go race detector becausehandleSend
gets invoked in a goroutine and there is no synchronization between that goroutine and a subsequent write toerr
after a call tostream.Header
.This appears to be an accidental closure --
handleSend
doesn't actually need to share theerr
variable so can instead just create its ownerr
local variable. Which clears it up.