Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bazel buildtools dependency #4980

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

AlejoAsd
Copy link
Contributor

References to other Issues or PRs

#4974 attempted to fix an issue reported in this PR comment. This turned out not to completely fix the issue.

This PR introduces an alternate fix that has been verified to work in a downstream project that imports grpc_gateway as a Bazel dependency.

Have you read the Contributing Guidelines?

Brief description of what is fixed or changed

Other comments

@AlejoAsd AlejoAsd changed the title Bazel: Get buildtools directly Fix Bazel buildtools dependency Nov 21, 2024
@AlejoAsd AlejoAsd changed the title Fix Bazel buildtools dependency Fix Bazel buildtools dependency Nov 21, 2024
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know some of these words

@johanbrandhorst johanbrandhorst merged commit e800153 into grpc-ecosystem:main Nov 22, 2024
14 checks passed
@AlejoAsd AlejoAsd deleted the fix_bazel_module_deps branch November 22, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants