chore: use errors.Is to compare errors in generated code #4971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
force-pushed
the
template/errors-is
branch
from
899671a
to
164b1fd
Compare
mmorel-35
changed the title
mmorel-35
force-pushed
the
template/errors-is
branch
from
164b1fd
to
dcedd35
Compare
mmorel-35
force-pushed
the
template/errors-is
branch
2 times, most recently
from
58810aa
to
ccecc38
Compare
johanbrandhorst
requested changes
Nov 21, 2024
mmorel-35
force-pushed
the
template/errors-is
branch
from
ccecc38
to
04b5624
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
template/errors-is
branch
from
04b5624
to
5ac3a26
Compare
johanbrandhorst
approved these changes
Nov 21, 2024
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This uses errors.Is to compare errors in generated code.
This the recommended way to compare errors (with erros.As but do not apply here). There is a linter (errorlint) that ensure this.