Fixed required body parameter when part of the proto message is path param #4850
+214
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e case where path params are present inside the field
…ter-of-proto-message-with-path-param
… message field and one of the field within this message field is part of path parameters; the message field now gets marked as required
…ter-of-proto-message-with-path-param
|
Looks like some of the generated files need updating, see the steps in CONTRIBUTING.md |
…ter-of-proto-message-with-path-param
johanbrandhorst
approved these changes
Oct 21, 2024
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs
Fixes #4666
Have you read the Contributing Guidelines?
Yes
Brief description of what is fixed or changed
If a message field (in the body) is marked as required and it contains a field which is part of the path parameters, then the OpenAPI Swagger object created does not show this message field as required. Inside the
renderFieldAsDefinition, code togetFieldBehaviorOption()is added when path params exists so that the required property of the message field can be captured.Other comments