Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow a change of go package name convention in protoc-gen-go #48

Merged
merged 2 commits into from
Sep 2, 2015

Conversation

yugui
Copy link
Member

@yugui yugui commented Sep 1, 2015

Follows the change golang/protobuf@dded913.

This fixes #22 as a side-effect.

The code generator module needs to reserve package names like "proto"
before code generation request is loaded so that go package name for
important packages like "github.com/golang/protobuf/proto" in the
generated code are stable.
@hayate
Copy link

hayate commented Sep 2, 2015

LGTM

yugui added a commit that referenced this pull request Sep 2, 2015
Follow a change of go package name convention in protoc-gen-go
@yugui yugui merged commit 9078b50 into master Sep 2, 2015
@yugui yugui deleted the feature/package-inconsistency branch January 28, 2016 05:50
ithinker1991 pushed a commit to tronprotocol/grpc-gateway that referenced this pull request May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple .proto files generates invalid import statements.
2 participants