Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed build error with golang 1.8.1 related to metadata.Context. #373

Closed
wants to merge 1 commit into from
Closed

Fixed build error with golang 1.8.1 related to metadata.Context. #373

wants to merge 1 commit into from

Conversation

rickcrawford
Copy link

Latest version appears to have a breaking API change.

$ go build ./...
# github.com/grpc-ecosystem/grpc-gateway/runtime
runtime/context.go:99: undefined: metadata.NewOutgoingContext

$ go test ./...
# github.com/grpc-ecosystem/grpc-gateway/runtime_test
runtime/context_test.go:31: undefined: metadata.FromOutgoingContext
runtime/context_test.go:53: undefined: metadata.FromOutgoingContext
runtime/context_test.go:85: undefined: metadata.FromOutgoingContext

@rickcrawford
Fixed build error with golang 1.8.1 related to metadata.Context.
9f5f41f 
Latest version appears to have a breaking API change.
@tamalsaha
Copy link
Collaborator

@rickcrawford , you are using an old version of grpc-go repo. Please see prior discussion here: #364

@rickcrawford
Copy link
Author

@tamalsaha thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickcrawford @tamalsaha