Fix #119 - CloseNotify race with ServeHTTP #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated code for the mux handlers can panic if the call to ServeHTTP() finishes before the goroutine finishes. This is because CloseNotify() can only be called before ServeHTTP() finishes. I've fixed this by calling CloseNotify() before starting the goroutine. The returned channel can safely be selected any time after that.
|
LGTM |
yugui
added a commit
that referenced
this pull request
Mar 3, 2016
Fix #119 - CloseNotify race with ServeHTTP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated code for the mux handlers can panic if the call to
ServeHTTP()finishes before the goroutine finishes. This is becauseCloseNotify()can only be called beforeServeHTTP()finishes. I'vefixed this by calling
CloseNotify()before starting the goroutine. Thereturned channel can safely be selected any time after that.