Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-swagger: add flag to disable default errors #1141

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

johanbrandhorst
Copy link
Collaborator

The new flag disable_default_errors can be used to disable
the generation of the default error types. This is suitable
for users that define their own error formatting.

The new flag disable_default_errors can be used to disable
the generation of the default error types. This is suitable
for users that define their own error formatting.
@johanbrandhorst
Copy link
Collaborator Author

Tested this by manually generating all the swagger files with this enabled and it produces the expected output.

@codecov-io
Copy link

Codecov Report

Merging #1141 into master will decrease coverage by 0.05%.
The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1141      +/-   ##
==========================================
- Coverage   53.79%   53.73%   -0.06%     
==========================================
  Files          42       42              
  Lines        4207     4213       +6     
==========================================
+ Hits         2263     2264       +1     
- Misses       1696     1701       +5     
  Partials      248      248
Impacted Files Coverage Δ
protoc-gen-swagger/main.go 26.6% <0%> (-0.25%) ⬇️
protoc-gen-grpc-gateway/descriptor/registry.go 56.77% <0%> (-0.98%) ⬇️
protoc-gen-swagger/genswagger/template.go 56.76% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 000dde5...598dd81. Read the comment docs.

Copy link
Contributor

@jgiles jgiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanbrandhorst johanbrandhorst merged commit df4ff8d into master Mar 2, 2020
@johanbrandhorst johanbrandhorst deleted the add-error-generation-flag branch March 2, 2020 14:30
michilu added a commit to michilu/proto-api that referenced this pull request Sep 19, 2023
- protoc-gen-swagger: add flag to disable default errors by johanbrandhorst · Pull Request #1141 · grpc-ecosystem/grpc-gateway grpc-ecosystem/grpc-gateway#1141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants