Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go integration tests are somewhat flaky #992

Closed
johanbrandhorst opened this issue Aug 12, 2019 · 1 comment
Closed

Go integration tests are somewhat flaky #992

johanbrandhorst opened this issue Aug 12, 2019 · 1 comment

Comments

@johanbrandhorst
Copy link
Collaborator

This doesn't happen with anything like the regularity of the bazel tests as described in #968, but it is still happening for unrelated changes. See https://circleci.com/gh/grpc-ecosystem/grpc-gateway/3630 for an example test failure:

--- FAIL: TestResponseBody (0.01s)
    --- FAIL: TestResponseBody/0 (0.00s)
        integration_test.go:1509: http.Get("http://localhost:8081/responsestrings/foo") failed with Get http://localhost:8081/responsestrings/foo: dial tcp 127.0.0.1:8081: connect: connection refused; want success

I think this is a just a race condition on startup, and we might be able to fix it by just introducing a longer sleep on startup.
srenatus added a commit to srenatus/grpc-gateway that referenced this issue Sep 11, 2019
@srenatus
examples/integration: wait for secondary gateway
c860678 
I haven't been able to reproduce grpc-ecosystem#992, but this looks like a likely fix. ;)

Signed-off-by: Stephan Renatus <[email protected]>
@srenatus srenatus mentioned this issue Sep 11, 2019
Merged
johanbrandhorst pushed a commit that referenced this issue Sep 11, 2019
@srenatus @johanbrandhorst
examples/integration: wait for secondary gateway
6ec92bb 
I haven't been able to reproduce #992, but this looks like a likely fix. ;)

Signed-off-by: Stephan Renatus <[email protected]>
@johanbrandhorst
Copy link
Collaborator Author

Fixed in #1039

adasari pushed a commit to adasari/grpc-gateway that referenced this issue Apr 9, 2020
@srenatus @johanbrandhorst
examples/integration: wait for secondary gateway
d1f030f 
I haven't been able to reproduce grpc-ecosystem#992, but this looks like a likely fix. ;)

Signed-off-by: Stephan Renatus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johanbrandhorst