We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
see title.
Steps to reproduce:
service.proto
service.pb.go
func NewNameClient
Name
service.pb.gw.go
NewnameClient
name
this looks similar to #300 and looks like it could be fixed in the same way.
the style guide, https://developers.google.com/protocol-buffers/docs/style, says you should capitalize service names, but seems it does not say it requires capitalized. So i think this is a valid bug
The text was updated successfully, but these errors were encountered:
I think you're totally correct. This would be a nice contribution for a first timer. I'll even point you to the appropriate code if you want 😉
Sorry, something went wrong.
Converts the first letter of service name to uppercase
5ff0781
fixes grpc-ecosystem#484
1636490
Converts the first letter of service name to uppercase (#522)
0a81003
Fixes: #484
Converts the first letter of service name to uppercase (grpc-ecosyste…
67487e1
…m#522) Fixes: grpc-ecosystem#484
Successfully merging a pull request may close this issue.
see title.
Steps to reproduce:
service.proto
service.pb.go
(notice that the generated code includesfunc NewNameClient
-- it is capitalizedName
)service.pb.gw.go
(notice that the generated code attempts to callNewnameClient
-- uncapitalizedname
which leads to the runtime error)this looks similar to #300 and looks like it could be fixed in the same way.
the style guide, https://developers.google.com/protocol-buffers/docs/style, says you should capitalize service names, but seems it does not say it requires capitalized. So i think this is a valid bug
The text was updated successfully, but these errors were encountered: