Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SOAP proxy #339

Closed
tgulacsi opened this issue Mar 28, 2017 · 7 comments
Closed

Add SOAP proxy #339

tgulacsi opened this issue Mar 28, 2017 · 7 comments

Comments

@tgulacsi
Copy link

Hi,

I have a SOAP proxy with WSDL generator under github.com/UNO-SOFT/soap-proxy.
Can you give some guidance how to add that to grpc-gateway?

@tmc
Copy link
Collaborator

tmc commented Mar 28, 2017

@tgulacsi thanks for your comment and for publishing your work there. It's not immediately clear to me how/if a SOAP bridge is appropriate in this project. I imagine with some hinting information a custom marshaller could get you most of the way there. Please propose enhancements to this project if there is something limiting your ability to implement this.

@tgulacsi
Copy link
Author

I do have a working JSON and SOAP proxy for gRPC.
I've moved with json to grpc-gateway, and wanted to move with the SOAP proxy, too.

I can generate the WSDL and have the Marshal/Unmarshal code for the SOAP HTTP handler.
I wanted to get some suggestions how to integrate it into grpc-gateway.

A SOAP bridge is just as appropriate as a JSON bridge - although I do hate SOAP, I have to support it.
But if this is too much of a maintenance hurdle and nobody is interested in SOAP, I'll keep that generator and handler separate.

@ghost
Copy link

ghost commented Apr 10, 2017

@tmc i would def use this !!!!
@tgulacsi this sounds really useful. I hate SOAP too but have to use it ...

@achew22
Copy link
Collaborator

achew22 commented Apr 11, 2017

@tgulacsi what an interesting project! I'd never even thought of using protos to define WSDLs. Neat!

Can you help me understand why you want this integrated into gRPC gateway directly? It doesn't appear to have any overlapping code and I think could be installed in parallel with a gRPC gateway server. What would the advantage of commingling the repositories over leaving them separate and composable?

@tgulacsi
Copy link
Author

@achew22 you're right, grpc-gateway and soap-proxy has no common code yet, but that can change easily: beside the wsdl generating code, the HTTP server that receives the json/soap, decodes it, calls the gRPC endpoint, encodes the response and sends it back has a lot in common.

And grpc-gateway can become a nice general gateway to gRPC - in this form this is just a json proxy, tbh.
I have code for XML-RPC, too :)

I do understand though if we keep grpc-gateway almost as-is, and provide these additional encoders/decoders as some sort of plugins/additions.

@ghost
Copy link

ghost commented Apr 11, 2017

@tgulacsi
i was wondring if you would be ok with putting a working example for the WSDL and xml-rpc in your repo ? From the looks of it its expecting a PB thats not in the source.

I am playing around with different gateways just like your code does. So having the REST with WSDL and xml.rpc is really useful.

On other thing i am looking at trying out with code gen, which your currently doing from the PB, is to map the PB types to Minio for durable storage and also incorporating NATS with it.

tgulacsi added a commit to UNO-SOFT/soap-proxy that referenced this issue Apr 15, 2017
@achew22
Copy link
Collaborator

achew22 commented Dec 14, 2017

Looks like you've created this already, cool! I look forward to seeing your project grow

https://github.com/UNO-SOFT/soap-proxy

@achew22 achew22 closed this as completed Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants