-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protoc-gen-swagger comment parsing for documentation gen #128
Comments
Unfortunately that is not something that I implemented. Fortunately I don't think it would be extremely difficult if you wanted to take a swing at contributing. The comments are in the SourceCodeInfo_Location object inside the FileDescriptorProto when genswagger iterates over the files. If you need more pointers than that please comment on this issue and I'll see what I can do. Thanks for reaching out! |
While this is a first step in resolving grpc-ecosystem#128, this needs to be cleaned up, and the same approach needs to be used for messages, message fields, et al. echo_service.proto has been annotated with extra comments in order to demo the new descriptions. Only the Swagger example has been regenerated, as my local generator does not output all the expected fields in proto struct tags.
While this is a first step in resolving grpc-ecosystem#128, this needs to be cleaned up, and the same approach needs to be used for messages, message fields, et al. echo_service.proto has been annotated with extra comments in order to demo the new descriptions. Only the Swagger example has been regenerated, as my local generator does not output all the expected fields in proto struct tags.
It looks like #134 covers this issue. Hopefully that will be merged in soon. |
Is there, by chance, any documentation on how to properly format comments so that the swagger fields in the JSON will be nicely populated for documentation purposes?
The text was updated successfully, but these errors were encountered: