-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jfbrandhorst/grpc-gateway-build-env image can't run on Windows #1073
Comments
@johanbrandhorst could I have you move this over to the other repo? |
The first error is because of a docker hub issue. I would like to move the image hosting to GitHub once the package registry is GA (13th of Nov AFAIK). The second error I'm not so sure about, but I will have a look when I have time. @achew22 not sure what you mean by moving the image? |
Sorry, I was talking about the issue not the image. Words are hard. Please leave this until you're back and settled at home |
I've re-pushed the 1.13 image, and it should now be pullable: https://hub.docker.com/r/jfbrandhorst/grpc-gateway-build-env/tags. I've opened a PR to fix the generation instructions: #1074. This should fix the issue. Thanks for the report @someone1. Let me know if you still have issues. |
The
jfbrandhorst/grpc-gateway-build-env:1.13
image can't be pulled in a Windows docker environment:And running it as described in the contributing doc from a linux environment errors with:
protoc -I /usr/local/bin//../include -I. -Ithird_party/googleapis --plugin=bin/protoc-gen-swagger --swagger_out=logtostderr=true,allow_repeated_fields_in_body=true,use_go_templates=true,Mgoogle/protobuf/field_mask.proto=google.golang.org/genproto/protobuf/field_mask,Mgoogle/protobuf/descriptor.proto=github.com/golang/protobuf/protoc-gen-go/descriptor,Mexamples/proto/sub/message.proto=github.com/grpc-ecosystem/grpc-gateway/examples/proto/sub,grpc_api_configuration=examples/proto/examplepb/unannotated_echo_service.yaml:. examples/proto/examplepb/echo_service.proto examples/proto/examplepb/a_bit_of_everything.proto examples/proto/examplepb/wrappers.proto examples/proto/examplepb/stream.proto examples/proto/examplepb/unannotated_echo_service.proto examples/proto/examplepb/use_go_template.proto examples/proto/examplepb/response_body_service.proto generate -i examples/proto/examplepb/echo_service.swagger.json \ -l go -o examples/clients/echo --additional-properties packageName=echo make: generate: Command not found make: *** [Makefile:169: examples/clients/echo/client.go] Error 127
Originally posted by @someone1 in #1072 (comment)
The text was updated successfully, but these errors were encountered: