runtime: make default marshaler emit default values

Fixes #233
grpc-ecosystem · May 22, 2020 · 172e2e2 · 172e2e2
1 parent 3ed822c
commit 172e2e2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/examples/internal/integration/integration_test.go b/examples/internal/integration/integration_test.go
@@ -1683,7 +1683,7 @@ func testResponseStrings(t *testing.T, port int) {
 			t.Errorf("marshaler.Unmarshal failed with %v; want success", err)
 			return
 		}
-		var want []string
+		want := []string{}
 		if diff := cmp.Diff(got, want); diff != "" {
 			t.Errorf(diff)
 		}

diff --git a/runtime/marshaler_registry.go b/runtime/marshaler_registry.go
@@ -17,8 +17,7 @@ var (
 
 	defaultMarshaler = &JSONPb{
 		MarshalOptions: protojson.MarshalOptions{
-			// TODO(johanbrandhorst): Change this to true before v2
-			EmitUnpopulated: false,
+			EmitUnpopulated: true,
 		},
 	}
 )