This repository has been archived by the owner on Apr 18, 2023. It is now read-only.
Some cleanups for megacheck warnings #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes: server_test.go:300:14:warning: grpc.Errorf is deprecated: use status.Errorf instead. (SA1019) (megacheck) server_test.go:305:10:warning: grpc.Errorf is deprecated: use status.Errorf instead. (SA1019) (megacheck)
This fixes: util.go:40:5: should omit comparison to bool constant, can be simplified to !mInfo.IsClientStream (S1002) util.go:40:38: should omit comparison to bool constant, can be simplified to !mInfo.IsServerStream (S1002) util.go:43:5: should omit comparison to bool constant, can be simplified to mInfo.IsClientStream (S1002) util.go:43:37: should omit comparison to bool constant, can be simplified to !mInfo.IsServerStream (S1002) util.go:46:5: should omit comparison to bool constant, can be simplified to !mInfo.IsClientStream (S1002) util.go:46:38: should omit comparison to bool constant, can be simplified to mInfo.IsServerStream (S1002)
This fixes: client_metrics.go:115:19: grpc.Code is deprecated: use status.FromError and Code method instead. (SA1019) client_metrics.go:126:20: grpc.Code is deprecated: use status.FromError and Code method instead. (SA1019) client_metrics.go:163:21: grpc.Code is deprecated: use status.FromError and Code method instead. (SA1019) client_test.go:164:49: grpc.Code is deprecated: use status.FromError and Code method instead. (SA1019) client_test.go:192:49: grpc.Code is deprecated: use status.FromError and Code method instead. (SA1019) server_metrics.go:107:19: grpc.Code is deprecated: use status.FromError and Code method instead. (SA1019) server_metrics.go:120:19: grpc.Code is deprecated: use status.FromError and Code method instead. (SA1019)
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
Please see #40 regarding the Travis-CI failure. |
Closed
|
@knweiss you also need to sign the CLA for us to be able to merge these changes. Also even if flaky I'd prefer to see the tests pass. |
Merged
|
@brancz done |
|
CLAs look good, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 77.4% 77.45% +0.04%
==========================================
Files 8 8
Lines 270 275 +5
==========================================
+ Hits 209 213 +4
- Misses 52 53 +1
Partials 9 9
Continue to review full report at Codecov.
|
|
lgtm |
bwplotka
reviewed
Apr 18, 2018
| @@ -37,13 +37,13 @@ func splitMethodName(fullMethodName string) (string, string) { | |||
| } | |||
|
|
|||
| func typeFromMethodInfo(mInfo *grpc.MethodInfo) grpcType { | |||
| if mInfo.IsClientStream == false && mInfo.IsServerStream == false { | |||
| if !mInfo.IsClientStream && !mInfo.IsServerStream { | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review (esp the
grpc.Code()commit).See the individual commit messages for details.
I've only tested with
go testso far.