logging: add WithErrorFields #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kindermoumoute
force-pushed
the
with-error-fields
branch
from
8e364e9 to
a43cd93
Compare
WithErrorFields allows to extract logging fields from an error. Typically to add a stack trace field or more context around the error. Signed-off-by: Olivier Cano <[email protected]>
kindermoumoute
force-pushed
the
with-error-fields
branch
from
a43cd93 to
9f0d68a
Compare
johanbrandhorst
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically to add a stack trace field or more context around the error.
Changes
WithErrorFieldsoptionwrappedErrFieldsand helpers to inject / extract fieldswrappedErrFieldsVerification
In PingError test (logging interceptor), assertion on finished fields show
"error-field"is present and set to the correct value.