Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client unary interceptor timeout #329

Conversation

instabledesign
Copy link
Contributor

👋 Hi,

what do you think about this addition?

Do you think it must purpose a most open way to determine the timeout (base on request or other input) in order to have a better control.

Let me know if this functionality already exist, and where?

Thank's for reading

@johanbrandhorst
Copy link
Collaborator

This is a cool idea, I don't think there is anything like it. We're currently working on finishing off the v2 branch though, and I'm wondering if you'd like to submit this against v2 instead? Also, one of the file contains a copyright header, and I'm not sure that will be possible to contribute to this repository. Are you the owner of the copyright?

@instabledesign
Copy link
Contributor Author

I thank,
to be honest i just copy paste the copyright from the recovery in order to have a PR as much similar as i can.
I am not the owner of this copyright comment bloc but the code is mine.
Should i just put my name, or delete the complete copyright?

@johanbrandhorst
Copy link
Collaborator

You should just remove it, it is not necessary.

@johanbrandhorst
Copy link
Collaborator

I'd like users to move to v2, so maybe we shouldn't merge this to v1? What do you think?

@instabledesign
Copy link
Contributor Author

Yeah let's encourage them to upgrade to v2, feel free to close this one 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants