Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'hello' example to use glutin v0.31 and winit v0.29 #276

Merged
merged 6 commits into from
Feb 2, 2024

Conversation

dmbfm
Copy link
Contributor

@dmbfm dmbfm commented Feb 1, 2024

Related to issue #249.

Since glutin no longer bundles winit, we need a lot of additional dependencies now: winit, glutin-winit and raw-window-handle. I grouped them in a feature named glutin_winit.

The boilerplate to configure the window is a lot longer as well. I am not 100% sure I configured everything correctly, but I mostly stuck with the example code in the glutin repo.

@dmbfm dmbfm changed the title Update 'hello' example to use glutin v0.31 and win v0.29 Update 'hello' example to use glutin v0.31 and winit v0.29 Feb 1, 2024
@grovesNL
Copy link
Owner

grovesNL commented Feb 2, 2024

You can bump the pinned Rust version to 1.64 to get that last build working -- I think the two places are the README and the CI configuration

@dmbfm
Copy link
Contributor Author

dmbfm commented Feb 2, 2024

Thanks, I'll do that!

@dmbfm
Copy link
Contributor Author

dmbfm commented Feb 2, 2024

@grovesNL It seems we need 1.65... is that ok?

@grovesNL
Copy link
Owner

grovesNL commented Feb 2, 2024

Sure, let's bump it to 1.65

Copy link
Owner

@grovesNL grovesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! The window/context setup code all seems reasonable to me

@grovesNL grovesNL merged commit a84e58f into grovesNL:main Feb 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants