Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Clarify that timeout applies to unset #36

Merged
merged 1 commit into from
Jun 11, 2017
Merged

docs: Clarify that timeout applies to unset #36

merged 1 commit into from
Jun 11, 2017

Conversation

zmackie
Copy link

@zmackie zmackie commented Jun 9, 2017

The documentation for setDefaults implies that timemouts only apply to get and set, when it appears tthat the also apply to unset. This fixes that unclarity.

jkrems
jkrems approved these changes Jun 11, 2017
View reviewed changes
Copy link
Contributor

@jkrems jkrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: - Thanks! That's what we get for routinely forgetting that cache deletes are a thing.

@jkrems jkrems merged commit b8314e5 into groupon:master Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkrems jkrems jkrems approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zmackie @jkrems @Zanadar