True timeouts for cache calls #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -98,8 +98,16 @@ Cache.prototype.set = function set(rawKey, val, _opts, _cb) { | |||
| return this._set(key, val, optsWithDefaults).nodeify(args.cb); | |||
| }; | |||
|
|
|||
| Cache.prototype._applyTimeout = function _applyTimeout(value) { | |||
| var timeoutMs = this.defaults.timeout; | |||
There was a problem hiding this comment.
timeout should be added to the README where you mention Cache.setDefaults(defaults)
There was a problem hiding this comment.
Good point. Added to the docs, stressing how important it is.
|
LGTM. Adding timeout logic like this always makes me nervous that it will work fine in simple test cases but behavior weirdly under high load/concurrency. But I guess the only way to verify that is to test it under high load :) |
|
Yeah, I have similar concerns. But I think because the actual sockets aren't opened per command but via a central pool, letting them "hang" shouldn't lead to resource exhaustion. Hopefully. ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of potential improvements that I didn't include in here, such as:
gofer-likeglobalDefaultssetting that applies to all cachesgofer-like default timeout so cache calls never have no timeout at allThe latter would be a breaking change, so I kept it to the bare minimum.