SFX-95: Testing Setup #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Install nyc, source-map-support, ts-node, nyc-config-typescript. - Add test and tdd scripts to package level. - Add "mocha" types to tsconfig
sinon-chai makes assertions using chai expect and sinon less awkward
This keeps tests isolated.
- Make singleRun = true default. - Change chrome browser to headless
jmbtutor
suggested changes
Jun 26, 2019
jmbtutor
reviewed
Jun 27, 2019
jmbtutor
approved these changes
Jul 2, 2019
| @@ -0,0 +1,20 @@ | |||
| import { expect, stub } from '../../utils'; | |||
There was a problem hiding this comment.
This was a source of great pain for me. I didn't manage to get the same file running in Karma and Mocha. I'm curious if you ran into any issues here.
There was a problem hiding this comment.
Plenty of issues.... Every time we added a new tool for testing it would break.
DanielMoniz-GBI
suggested changes
Jul 2, 2019
DanielMoniz-GBI
approved these changes
Jul 3, 2019
JoeyDeol
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION: