Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undoing wsdiscovery's logging configuration #59

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

timmarkhuff
Copy link
Contributor

wsdiscovery, a depedency of framegrab calls logging.basicConfig, which is not good. This will override an logging configurations that framegrab users attempt to set. This PR removes that config.

Here is some output from my machine that pointed me towards the fact that wsdicovery was calling logging.basicConfig

tim@tim:~/gl-demo$ grep -r "basicConfig" $(poetry env info --path)/lib/python*/site-packages/
/home/tim/gl-demo/.venv/lib/python3.11/site-packages/wsdiscovery/cmdline.py:logging.basicConfig()
/home/tim/gl-demo/.venv/lib/python3.11/site-packages/wsdiscovery/asynch.py:logging.basicConfig()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant