Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #29

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
</p>

## What is Murre?
Murre is an **on-demand, scaleable source of container resource metrics for K8s**.
Murre is an **on-demand, scalable source of container resource metrics for K8s**.

Murre fetchs CPU & memory resource metrics directly from the kubelet on each K8s Node.
Murre fetches CPU & memory resource metrics directly from the kubelet on each K8s Node.
Murre also enriches the resources with the relevant K8s requests and limits from each PodSpec.

## Why Murre?
Expand Down
6 changes: 3 additions & 3 deletions pkg/murre.go
Original file line number Diff line number Diff line change
Expand Up @@ -137,16 +137,16 @@ func (m *Murre) updateContainers() error {
}

func (m *Murre) filter(stats []*k8s.Stats) []*k8s.Stats {
filterdStats := make([]*k8s.Stats, 0)
filteredStats := make([]*k8s.Stats, 0)
for _, s := range stats {
isNamespaceMatch := m.config.Filters.Namespace == "" || m.config.Filters.Namespace == s.Namespace
isPodMatch := m.config.Filters.Pod == "" || m.config.Filters.Pod == s.PodName
isContainerMatch := m.config.Filters.Container == "" || m.config.Filters.Container == s.ContainerName
if isNamespaceMatch && isPodMatch && isContainerMatch {
filterdStats = append(filterdStats, s)
filteredStats = append(filteredStats, s)
}
}
return filterdStats
return filteredStats
}

func (m *Murre) sort(stats []*k8s.Stats) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/ui/table.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ func (t *Table) getCell(stats *k8s.Stats, column int) *tview.TableCell {
return tview.NewTableCell("\u23F1").SetAlign(tview.AlignCenter)
}

//convet bytes to MiB
//convert bytes to MiB
memoryInMiB := stats.MemoryBytes / 1024 / 1024
memoryLimitInMib := stats.MemoryLimitBytes / 1024 / 1024
if stats.MemoryUsagePercent > 0 {
Expand Down