[sc-12837] install flow should wait for static amount of pvcs #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #12837: CLI Should expect static number of PVCs. |
steb-veksler
approved these changes
Jan 11, 2024
avivzgroundcover
deleted the
avivzohari/sc-12837/cli-should-expect-static-number-of-pvcs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases installing the helm chart does not result in PVCs getting created. Currently this results in a clean return with nil error, which then leads to faulty installations.
This PR changes the way the CLI gets the expected number of PVCs to wait for in the waitForPVCs function - to a static amount and not dynamic according to kubectl result.