Skip to content

Commit

Permalink
TODO.md: Add a #97 reminder.
Browse files Browse the repository at this point in the history
  • Loading branch information
@groue
groue committed Sep 10, 2015
1 parent 9a75765 commit 7a1880f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions TODO.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- [ ] #97: In commit 65a6593229ae8bad1630a82ccebb327fb4a9f1e3, Daniel removes a few tests based on Core Data. Make sure that we still have tests for Core Data: attributes are safe keys, and they should be rendered.

2 comments on commit 7a1880f

@danielphillips
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, those two tests although they were touching into Core Data they were no longer needed after we removed the preventNSUndefinedKeyExceptionAttack feature correct? Is this a reminder to add extra Core Data related tests or did I do something wrong?

@groue
Copy link
Owner Author

@groue groue commented on 7a1880f Sep 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Daniel. We need to test that Core Data attributes are visible from templates.

The safety mechanism makes {{ x }} fail unless x is "safe", which means backed by a property, or by Core Data (Core Data attributes are not exposed as ObjC properties, and require extra check).

So unless we have an explicit test for it, we may break Core Data support without noticing it.

This TODO item is just a reminder. Maybe we already have a test, maybe not.

Please sign in to comment.