Make sure no error is raised when a process is already terminated #939
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Sometime when using
parallel_rspec --fail-fast --test-options '--fail-fast'
, it can happen that the process is already gone beforestop_all_processes
has time to kill it. In this caseErrno::ESRCH
was raised. Rescuing the error ensures that the exits happen as expected for the parent process itself.Fix errors like that:
Wasn't sure a changelog entry was required. Let me know if you'd like one.
Checklist
master
(if not - rebase it).code introduces user-observable changes.