-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testCompile using groovy-eclipse-compiler fails with error about --patch-modules #987
Comments
Could you enable verbose setting on the compiler and include the command line arguments being passed to |
sure! I don't have any compilerArgs set on the maven-compiler-plugin. Here's my maven-compiler-plugin config:
and here's the verbose output:
|
So, it looks like the following arguments are being passed (besides source files to compile):
|
At the end of String prev = null;
for (Map.Entry<String, String> entry : config.getCustomCompilerArgumentsAsMap().entrySet()) {
String key = entry.getKey();
if (key.startsWith("-")) {
if ("-javaAgentClass".equals(key)) {
setJavaAgentClass(entry.getValue());
} else if (!key.startsWith("-J")) {
args.put(key, entry.getValue());
} else {
vmArgs.add(key.substring(2));
}
prev = (entry.getValue() == null ? key : null);
} else {
if (prev != null && entry.getValue() == null) {
args.put(prev, key);
} else if (!"org.osgi.framework.system.packages".equals(key)) { // GRECLIPSE-1418: ignore the system packages option
args.put("-" + key, entry.getValue());
}
prev = null;
}
}
args.remove("--patch-module"); // https://github.com/groovy/groovy-eclipse/issues/987 Then you can run "mvn install" from the |
skip unsupported "--patch-module" command-line argument #987
When I add a module-info.java file to my main source set, the testCompile mojo fails with this error:
I'm currently using javac for my main sources, and groovy-eclipse for my test sources.
Environment details:
java: 11.0.5
maven: 3.6.2
maven-compiler-plugin: 3.8.1
groovy-eclipse-compiler: 3.6.0-01
groovy-eclipse-batch: 2.5.8-02
The text was updated successfully, but these errors were encountered: